Merge pull request 'Start a permanent Nextcloud 35 version line at 35.0.0' (#1 ) from nextcloud-35 into main

Reviewed-on: #1
Start a permanent Nextcloud 35 version line at 35.0.0
2026-09-22 07:37:47 +02:00 · 2026-09-22 07:36:15 +02:00 · 2026-08-26 07:10:55 +02:00 · 2026-08-25 15:28:30 +02:00 · 2026-08-25 15:28:21 +02:00
5 changed files with 9 additions and 7 deletions
@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co

 ## What this is

-A Nextcloud app (`workflow_deck_automation`, namespace `WorkflowDeckAutomation`) targeting **Nextcloud Hub 26 Spring (server 34.x)**. It lets each user configure, from their personal settings, automation "workflows" that move overdue [Deck](https://github.com/nextcloud/deck) cards from one stack to another, with optional assigned-user/label filters and an email notification. A background `Job` evaluates all enabled workflows on every cron pass.
+A Nextcloud app (`workflow_deck_automation`, namespace `WorkflowDeckAutomation`) targeting **Nextcloud Hub Summer 26 (server 35.x)** on this branch (`main` tracks Hub 26 Spring / server 34.x). It lets each user configure, from their personal settings, automation "workflows" that move overdue [Deck](https://github.com/nextcloud/deck) cards from one stack to another, with optional assigned-user/label filters and an email notification. A background `Job` evaluates all enabled workflows on every cron pass.

 ## Non-negotiable architectural constraint

@@ -109,7 +109,9 @@ There is no meaningful way to test the Deck integration itself outside a real Ne

 ### Release process

-**Versioning scheme (from 34.0.0 on): `<nextcloud-major>.<minor>.<patch>`.** The leading number tracks the minimum/maximum Nextcloud major version declared in `appinfo/info.xml`'s `<dependencies><nextcloud .../>` (currently `min-version="34" max-version="34"`), not this app's own feature history - so it only changes when the supported Nextcloud major changes (e.g. dropping/adding NC 34 support bumps to `35.0.0`), and resets `minor`/`patch` to `0.0` at that point. Ordinary fixes/features within the same supported NC major bump `minor`/`patch` as usual (semver-ish, without a leading `0.`). Versions before `34.0.0` (`0.1.x`/`0.2.x`) predate this scheme.
+**Versioning scheme (from 34.0.0 on): `<nextcloud-major>.<minor>.<patch>`.** The leading number tracks the minimum/maximum Nextcloud major version declared in `appinfo/info.xml`'s `<dependencies><nextcloud .../>` (on this branch `min-version="35" max-version="35"`), not this app's own feature history - so it only changes when the supported Nextcloud major changes, and resets `minor`/`patch` to `0.0` at that point. Ordinary fixes/features within the same supported NC major bump `minor`/`patch` as usual (semver-ish, without a leading `0.`). Versions before `34.0.0` (`0.1.x`/`0.2.x`) predate this scheme.
+
+This branch (`nextcloud-35`) is a permanent, separately maintained version line for Nextcloud 35, started at `35.0.0` alongside the `34.x.x` line on `main`. Backport fixes between the two lines manually where relevant; they are not merged into each other.

 1. Bump `<version>` in `appinfo/info.xml` and `version` in `package.json` (keep them in sync).
 2. Commit, push to `main`, confirm the run of `.gitea/workflows/build-main.yml` is green.
@@ -1,6 +1,6 @@
 # Deck Workflow-Automatisierung

-Nextcloud-App für **Nextcloud Hub 26 Spring (Server 34.x)**, die überfällige Karten der [Deck](https://github.com/nextcloud/deck)-App automatisch von einem Stapel in einen anderen verschiebt und optional eine E-Mail-Benachrichtigung verschickt.
+Nextcloud-App für **Nextcloud Hub Summer 26 (Server 35.x)**, die überfällige Karten der [Deck](https://github.com/nextcloud/deck)-App automatisch von einem Stapel in einen anderen verschiebt und optional eine E-Mail-Benachrichtigung verschickt.

 Ersetzt das früher genutzte eigenständige PHP-Cron-Skript durch eine vollwertige App mit Oberfläche in den **persönlichen Einstellungen** — jeder Nutzer kann dort seine eigenen Regeln ("Workflows") anlegen, ohne Admin-Rechte oder Server-Zugriff zu benötigen.

@@ -28,7 +28,7 @@ This app lets every user configure their own Deck automation workflows from Pers

 A background job periodically evaluates all enabled workflows and moves cards whose due date has passed, using Deck's own internal PHP classes only (no HTTP/OCS calls).
 ]]></description>
-    <version>34.0.2</version>
+    <version>35.0.0</version>
    <licence>agpl</licence>
    <author mail="patrick@niebel.ing">Patrick Niebeling</author>
    <namespace>WorkflowDeckAutomation</namespace>
@@ -40,7 +40,7 @@ A background job periodically evaluates all enabled workflows and moves cards wh
        <database min-version="9.4">pgsql</database>
        <database>sqlite</database>
        <database min-version="8.0">mysql</database>
-        <nextcloud min-version="34" max-version="34"/>
+        <nextcloud min-version="35" max-version="35"/>
    </dependencies>
    <background-jobs>
        <job>OCA\WorkflowDeckAutomation\BackgroundJob\RunWorkflowsJob</job>
@@ -29,6 +29,6 @@ class PersonalSection implements IIconSection {
 	}

 	public function getIcon(): string {
-		return $this->urlGenerator->imagePath(Application::APP_ID, 'app-dark.svg');
+		return $this->urlGenerator->imagePath(Application::APP_ID, 'app.svg');
 	}
 }
@@ -1,6 +1,6 @@
 {
 	"name": "workflow_deck_automation",
-	"version": "34.0.2",
+	"version": "35.0.0",
 	"private": true,
 	"type": "module",
 	"description": "Automates moving overdue Deck cards between stacks, configurable per user.",
Author	SHA1	Message	Date
gnilebein	7c7c52cb1c	Merge pull request 'Start a permanent Nextcloud 35 version line at 35.0.0' (#1 ) from nextcloud-35 into main Build package / php-lint (8.4) (push) Successful in 45s Details Build package / php-lint (8.5) (push) Successful in 41s Details Build package / xml-lint (push) Successful in 15s Details Build package / unit-tests (push) Successful in 41s Details Build package / package (push) Successful in 58s Details Reviewed-on: #1	2026-09-22 07:37:47 +02:00
Patrick Niebeling	dfec88d396	Start a permanent Nextcloud 35 version line at 35.0.0 Build package / php-lint (8.4) (push) Successful in 52s Details Build package / php-lint (8.5) (push) Successful in 49s Details Build package / xml-lint (push) Successful in 15s Details Build package / unit-tests (push) Successful in 45s Details Build package / php-lint (8.4) (pull_request) Successful in 47s Details Build package / php-lint (8.5) (pull_request) Successful in 45s Details Build package / xml-lint (pull_request) Successful in 13s Details Build package / unit-tests (pull_request) Successful in 49s Details Build package / package (push) Successful in 57s Details Build package / package (pull_request) Successful in 49s Details Nextcloud Hub Summer 26 (server 35.x) is declared as the sole supported major on this branch, per the existing versioning scheme (leading version number tracks the declared NC major). main keeps tracking Nextcloud 34 (Hub 26 Spring) at the 34.x.x line; the two are maintained in parallel rather than one replacing the other.	2026-09-22 07:36:15 +02:00
gnilebein	28b4edc811	revert `0e66319a06` Build package / php-lint (8.4) (push) Successful in 43s Details Build package / php-lint (8.5) (push) Successful in 40s Details Build package / xml-lint (push) Successful in 12s Details Build package / unit-tests (push) Successful in 38s Details Build package / package (push) Successful in 52s Details revert Let each workflow watch the due date or the start date Deck 1.18 added a start date to cards (Card::$startdate), so a workflow no longer has to mean "overdue". Each rule now carries a date_field ('due' \| 'start'), chosen in the settings form next to board and stacks. Existing rules keep the due date: the new column's default supplies it for every stored row, so there is no backfill step, and Workflow::getDateFieldOrDue() covers entities that were never near the database as well as hand-edited values. The controller is the one place that rejects an unknown value instead of normalising it - a client asking for a rule it would not get should hear about it. The probe for the field is property_exists(), not method_exists(): Deck's entities declare no getter as real code - getStartdate(), getDuedate(), even getId() all go through Entity::__call(), which method_exists() ignores by definition. A method_exists() guard would have been false on every Deck version and would have turned every start-date rule into a silent no-op. assertDeckAvailable() now also refuses Deck older than 1.18.0. That floor cannot live in appinfo/info.xml - neither the server's nor the app store's schema has an app-to-app dependency element - but <nextcloud min-version="34"> already implies it, since 1.18.x is the only Deck release line published for Nextcloud 34. isOverdue() becomes hasPassed(): one function for both dates, since the comparison and the argument against Deck's day-truncating getDaysUntilDue() are identical for either. Also carries a pending NcSelect icon-alignment fix that was already in the working tree. Bump to 34.1.0.	2026-08-26 07:10:55 +02:00
Patrick Niebeling	0e66319a06	Let each workflow watch the due date or the start date Build package / php-lint (8.4) (push) Successful in 39s Details Build package / php-lint (8.5) (push) Successful in 43s Details Build package / xml-lint (push) Successful in 13s Details Build package / unit-tests (push) Failing after 39s Details Build package / package (push) Skipped Details Deck 1.18 added a start date to cards (Card::$startdate), so a workflow no longer has to mean "overdue". Each rule now carries a date_field ('due' \| 'start'), chosen in the settings form next to board and stacks. Existing rules keep the due date: the new column's default supplies it for every stored row, so there is no backfill step, and Workflow::getDateFieldOrDue() covers entities that were never near the database as well as hand-edited values. The controller is the one place that rejects an unknown value instead of normalising it - a client asking for a rule it would not get should hear about it. The probe for the field is property_exists(), not method_exists(): Deck's entities declare no getter as real code - getStartdate(), getDuedate(), even getId() all go through Entity::__call(), which method_exists() ignores by definition. A method_exists() guard would have been false on every Deck version and would have turned every start-date rule into a silent no-op. assertDeckAvailable() now also refuses Deck older than 1.18.0. That floor cannot live in appinfo/info.xml - neither the server's nor the app store's schema has an app-to-app dependency element - but <nextcloud min-version="34"> already implies it, since 1.18.x is the only Deck release line published for Nextcloud 34. isOverdue() becomes hasPassed(): one function for both dates, since the comparison and the argument against Deck's day-truncating getDaysUntilDue() are identical for either. Also carries a pending NcSelect icon-alignment fix that was already in the working tree. Bump to 34.1.0.	2026-08-25 15:28:30 +02:00
Patrick Niebeling	43648f3728	Use app.svg for the personal settings section icon Was already pending in the working tree; committed unchanged.	2026-08-25 15:28:21 +02:00