Send moved-card notices as Nextcloud notifications too

Each workflow now has a notify channel (mail, notification or both) next
to its recipient mode. Notifications go out per card through
OCP\Notification\IManager, so they show up in the bell and as push on the
mobile and desktop clients. Without the notifications app nothing is sent.
The one-off "workflow disabled" notice is sent as a notification as well.

Existing workflows keep mail (migration Version1004). Bumps to 35.3.0 so
the migration runs.

lib/Controller/WorkflowController.php

@@ -57,13 +57,14 @@ class WorkflowController extends OCSController {
 		int $sourceStackId,
 		int $targetStackId,
 		string $notifyMode = NotificationPolicy::MODE_OFF,
+		string $notifyChannel = NotificationPolicy::CHANNEL_MAIL,
 		bool $enabled = true,
 	): DataResponse {
-		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $notifyMode);
+		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel);
 
 		$workflow = new Workflow();
 		$workflow->setUserId($this->currentUserId());
-		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $enabled);
+		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel, $enabled);
 
 		$workflow = $this->workflowMapper->insert($workflow);
 		return new DataResponse($workflow->jsonSerialize(), Http::STATUS_CREATED);
@@ -77,15 +78,16 @@ class WorkflowController extends OCSController {
 		int $sourceStackId,
 		int $targetStackId,
 		string $notifyMode = NotificationPolicy::MODE_OFF,
+		string $notifyChannel = NotificationPolicy::CHANNEL_MAIL,
 		bool $enabled = true,
 	): DataResponse {
 		$workflow = $this->findOwnWorkflow($id);
-		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $notifyMode);
+		$this->validate($title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel);
 
 		// Kept in step with the board owner so the job runs as, and mails,
 		// the right user; validate() made sure the editor owns the board.
 		$workflow->setUserId($this->currentUserId());
-		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $enabled);
+		$this->applyFields($workflow, $title, $boardId, $sourceStackId, $targetStackId, $notifyMode, $notifyChannel, $enabled);
 		$workflow = $this->workflowMapper->update($workflow);
 
 		return new DataResponse($workflow->jsonSerialize());
@@ -156,7 +158,7 @@ class WorkflowController extends OCSController {
 		}
 	}
 
-	private function validate(string $title, int $boardId, int $sourceStackId, int $targetStackId, string $notifyMode): void {
+	private function validate(string $title, int $boardId, int $sourceStackId, int $targetStackId, string $notifyMode, string $notifyChannel): void {
 		if (trim($title) === '') {
 			throw new OCSBadRequestException('Bitte einen Titel angeben.');
 		}
@@ -164,7 +166,10 @@ class WorkflowController extends OCSController {
 			throw new OCSBadRequestException('Quell- und Ziel-Stapel müssen sich unterscheiden.');
 		}
 		if (!NotificationPolicy::isValidMode($notifyMode)) {
-			throw new OCSBadRequestException('Ungültige E-Mail-Einstellung, erlaubt sind: ' . implode(', ', NotificationPolicy::MODES));
+			throw new OCSBadRequestException('Ungültige Benachrichtigungs-Einstellung, erlaubt sind: ' . implode(', ', NotificationPolicy::MODES));
+		}
+		if (!NotificationPolicy::isValidChannel($notifyChannel)) {
+			throw new OCSBadRequestException('Ungültiger Benachrichtigungsweg, erlaubt sind: ' . implode(', ', NotificationPolicy::CHANNELS));
 		}
 
 		// Reject references to boards or stacks that are gone (or were never
@@ -203,6 +208,7 @@ class WorkflowController extends OCSController {
 		int $sourceStackId,
 		int $targetStackId,
 		string $notifyMode,
+		string $notifyChannel,
 		bool $enabled,
 	): void {
 		$workflow->setTitle($title);
@@ -210,6 +216,7 @@ class WorkflowController extends OCSController {
 		$workflow->setSourceStackId($sourceStackId);
 		$workflow->setTargetStackId($targetStackId);
 		$workflow->setNotifyMode($notifyMode);
+		$workflow->setNotifyChannel($notifyChannel);
 		$workflow->setEnabled($enabled);
 	}
 }